fix: boost coverage to 90.6%, eliminate ~535 lines duplication, fix MD5 security hotspot#37
Merged
Merged
Conversation
- Extract DetectorDbHelper: shared ensureDbNode/addDbEdge utility used by TypeORM, Prisma, JPA, Repository detectors + AbstractPythonDbDetector delegates to it — removes ~150 lines of copy-paste across 5 files - Extract AbstractStructuredDetector.buildFileNode/addKeyNode: shared CONFIG_FILE node + CONTAINS edge boilerplate now used by JSON, YAML, TOML, IniStructureDetectors — removes ~50 lines of copy-paste - Extract CliOutput.printAnalysisStats/printBreakdowns: shared result output code now used by both AnalyzeCommand and IndexCommand — removes ~60 lines of copy-paste Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FileHasher(removes 2 SonarCloud hotspots); 75 ReDoS hotspots acknowledged as safe in SonarCloudDuplication fixes
AbstractPythonAntlrDetector+AbstractPythonDbDetectorDetectorDbHelper(shared ensureDbNode/addDbEdge)AbstractStructuredDetector.buildFileNode/addKeyNodeCliOutput.printAnalysisStats/printBreakdownsSecurity fixes
FileHasher: MD5 → SHA-256 for bothhash(Path)andhashString(String)FileHasherTest+CacheCoverageTestupdated for 64-char SHA-256 outputTest plan
🤖 Generated with Claude Code